Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: wasip1 is broken on wasmer runtime #59907

Open
johanbrandhorst opened this issue Apr 30, 2023 · 11 comments
Open

build: wasip1 is broken on wasmer runtime #59907

johanbrandhorst opened this issue Apr 30, 2023 · 11 comments
Labels
arch-wasm WebAssembly issues NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@johanbrandhorst
Copy link
Member

johanbrandhorst commented Apr 30, 2023 •
edited
Loading

This is a tracking issue for issues surrounding the use of the new wasip1 GOOS target on the wasmer Wasm runtime. We currently do not have a wasmer runner, but manual testing against the wasmer runtime has already yielded some results, namely, it is known that it exhibits a problem similar to wasmtime when it comes to opening directories (see #59583 (comment)).

This issue should not be considered done until we have a working wasmer runner and all tests are either passing or we have documented the failures which we cannot reasonably fix.

Currently known failing tests:

Package Test name Error Test log Fixed
archive/tar TestReader open testdata/gnu.tar: Bad file number Full log
@johanbrandhorst johanbrandhorst mentioned this issue Apr 30, 2023
Closed
@cagedmantis cagedmantis added arch-wasm WebAssembly issues NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 1, 2023
@cagedmantis cagedmantis added this to the Backlog milestone May 1, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/493755 mentions this issue: all: add wasmer wasip1 runner

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/493775 mentions this issue: misc/wasm: add wasmer to wasip1 script

gopherbot pushed a commit that referenced this issue May 9, 2023
@johanbrandhorst
misc/wasm: add wasmer to wasip1 script
5751939 
The wasmer runtime will be used to test our wasip1
implementation against the WASI runtime from wasmer.io.

For #59907

Change-Id: Ie7e48c39e03075815ddca46d996b6ec87009b12a
Reviewed-on: https://go-review.googlesource.com/c/go/+/493775
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
gopherbot pushed a commit to golang/build that referenced this issue May 9, 2023
@johanbrandhorst @gopherbot
all: add wasmer wasip1 runner
5ba5cf0 
The wasmer runner privdes the wasmer.io WASI runtime
for testing the wasip1 implementation.

For golang/go#59907

Change-Id: Ied892dd60d933666b53039ab1c9d3e3065c8800b
Reviewed-on: https://go-review.googlesource.com/c/build/+/493755
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
@johanbrandhorst
Copy link
Member Author

The runner has been added and once the builders have been redeployed I will run a test run to see what errors we hit.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/495077 mentions this issue: misc/wasm: test commit

@johanbrandhorst
Copy link
Member Author

The first runner test result against the wasmer runtime is in, and it seems that it's refusing to do any file opens, instead erroring with Bad file number on practically all attempts. More investigation will be necessary. I have updated the table at the top.

@jakebailey
Copy link

jakebailey commented May 18, 2023 •
edited
Loading

I'm sure you are aware of this, but if you're looking to just check the current status of the runners, the build dashboard does contain links to the most recent builds per commit (wasip1 is all the way on the right), and should be a more convenient way to look up the current failures than CLs like CL 495077 that need the trybots run. That's how I've been watching things, at least.

@johanbrandhorst
Copy link
Member Author

Haha, I didn't actually know that it'd run our broken runners against tip, thanks! I'm still using the CLs to add extra debugging in some cases (like CL 491855) so I'll probably keep them around for myself anyway :).

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/498616 mentions this issue: misc/wasm: set PATH variable in exec

gopherbot pushed a commit that referenced this issue May 26, 2023
@johanbrandhorst
misc/wasm: set PATH variable in exec
188066c 
The PATH variable is required to run the testenv tests.
Set it for all the runtime invocations where we don't
already set it by inheriting from the environment.

For #59583
For #59907
For #60097

Change-Id: If582dd8f086e3f40bc58d555f6034dcffe6f8e5f
Reviewed-on: https://go-review.googlesource.com/c/go/+/498616
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Closed
@tliron
Copy link

tliron commented Aug 23, 2023

For what it's worth, I have the same issue, but there is no error when running the same code using wasmtime. The issue seems specific to wasmer.

@achille-roussel
Copy link
Contributor

@syrusakbary maybe the wasmer team could help sort out the issue?

@johanbrandhorst johanbrandhorst mentioned this issue Sep 8, 2023
Closed
@arjunmalhotra1
Copy link

Hey @achille-roussel and @johanbrandhorst,
I will be happy to take a look at this if still unresolved and no one is working on this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@cagedmantis @achille-roussel @tliron @jakebailey @johanbrandhorst @gopherbot @arjunmalhotra1